Update icons in Modelica.Mechanics.MultiBody.Visualizers from Wolfram MathCore

[beutlich]

Use nicer icons from Wolfram SystemModeler for

• Modelica.Mechanics.MultiBody.Visualizers
• Modelica.Mechanics.MultiBody.Visualizers.Ground
• Modelica.Mechanics.MultiBody.Visualizers.Torus
• Modelica.Mechanics.MultiBody.Visualizers.VoluminousWheel
• Modelica.Mechanics.MultiBody.Visualizers.PipeWithScalarField
• Modelica.Mechanics.MultiBody.Visualizers.Advanced.PipeWithScalarField

@maltelenz @henrikt-ma For MSL v3.2 the icons were designed by @d-hedberg at Wolfram MathCore. Is it okay for you to take these six new icons for regular MSL again?

[maltelenz]

Yes, these are fine to use.

[henrikt-ma]

Fine, by nature of being approved by @maltelenz.

[tobolar]

What is the actual reason for this changes? To prefer image definition inside of a class instead of by an external image?

[beutlich]

No, to have nicer icons.

[tobolar]

Considering rendering in Dymola's package browser, Joints icon seems not to be better/nicer to me. Other components are fine.

Dymola's diagram:

[maltelenz]

The rendering of the Joints icon looks fine in SystemModeler, and reasonable in OpenModelica, so I think this is a Dymola problem.
SystemModeler:

OpenModelica:

Edit: Had the wrong version loaded for OpenModelica screenshot. Updated now, my comment still stands.
Edit 2: And here is the corresponding diagram with the new icons rendered by SystemModeler:

[beutlich]

Here's how the Joints icon looks in SimulationX.

MSL 3.2.3:

This PR:

I also prefer that we should stick with the old icon since drawing cylindric gradients seems problematic in small icons.

[beutlich]

And here's how the other new icons look in SimulationX:

[tobolar]

OK, let's focus on the Joints icon only. I'm going to prepare yet another atempt this morning and will let you know.

[tobolar]

Here are my attempts to improve the icons. In most cases, Dymola renders the cylinders poorly. In Joints6 I've used the same principle like in Torus and VoluminousWheel, i.e. overlayed several polygons. This seems fine to me.

@maltelenz, @beutlich: Please check in other tools whether this could be a solution.
https://gist.github.com/tobolar/95e62615d30ed5931cfd94c245040756

[maltelenz]

I added a 7 that is the 6 with a border.
I also fixed a typo in "rotation" in 1.
https://gist.github.com/maltelenz/098b8acaa0f079ff93aec93dcfd1187e

All look fine in SystemModeler:

This is OpenModelica:

To be honest, Dymolas rendering just looks broken, especially at the small sizes.

Edit: I'll make a bold statement: Broken tools should be ignored when writing a standard library for a language. We should use the originally suggested Joints icon. The majority of the tools had no trouble rendering it nicely, suggesting heavily that Dymola is just broken in this regard.

[beutlich]

Screen shot from SimulationX:

[tobolar]

Broken tools should be ignored when writing a standard library for a language.

In that case I would vote for Joints4 or Joints5. What I in particular preferre is: darker colors, larger circles representing the flange/bolt.

[maltelenz]

I like Joints4 as well.

[tobolar]

I'm in favor of reverting icon changes for Joints here and open another PR for it.