Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model stepped signals by constant interpolation of CombiTimeTable in MSL examples #3116

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Model stepped signals by constant interpolation of CombiTimeTable in MSL examples #3116

merged 1 commit into from
Sep 27, 2019

Conversation

beutlich
Copy link
Member

Model stepped signals by constant interpolation of CombiTimeTable and avoid misuse of linear interpolation with duplicated sample points.

See #3115.

@beutlich beutlich added the example Issue only addresses example(s) label Sep 10, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Sep 10, 2019
@beutlich beutlich self-assigned this Sep 10, 2019
HansOlsson
HansOlsson reviewed Sep 11, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added some comments - as I don't see the need for all of the changes.
The remaining changes look like improvements.

@beutlich
Copy link
Member Author

as I don't see the need for all of the changes.

@HansOlsson OK for you to keep these changes in anyway?

@HansOlsson
Copy link
Contributor

as I don't see the need for all of the changes.

@HansOlsson OK for you to keep these changes in anyway?

Yes.

@HansOlsson HansOlsson self-requested a review September 16, 2019 07:43
HansOlsson
HansOlsson approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to keep those changes as well.

@beutlich beutlich requested review from christiankral and removed request for christiankral September 16, 2019 20:07
@beutlich
Copy link
Member Author

@christiankral OK for you, too?

dietmarw
dietmarw approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@beutlich beutlich merged commit 8df7452 into modelica:master Sep 27, 2019
@beutlich beutlich deleted the avoid-misuse-duplicated-sample-points branch September 27, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
example Issue only addresses example(s)
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beutlich @HansOlsson @dietmarw