Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3165 by improving the icon design of the firing connector #3169

Merged
merged 4 commits into from
Oct 29, 2019
Merged

Fix #3165 by improving the icon design of the firing connector #3169

merged 4 commits into from
Oct 29, 2019

Conversation

dietmarw
Copy link
Member

@dietmarw dietmarw commented Oct 23, 2019 •
edited by beutlich

fix #3165

@dietmarw dietmarw self-assigned this Oct 23, 2019
@dietmarw dietmarw added the L: Electrical.Analog Issue addresses Modelica.Electrical.Analog label Oct 23, 2019
@dietmarw dietmarw mentioned this pull request Oct 23, 2019
Closed
@dietmarw dietmarw added this to the MSL4.0.0 milestone Oct 23, 2019
christiankral
christiankral reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong preference on what the icon exactly shall look like: Either one is fine, with or without dotted line. So in general I am OK with the proposed changes. I yet think that we shall maintain a uniform appearance of all MSL (semiconductor) models. As the ideal thyristor model is corrected, the model Modelica.Electrical.Analog.Semiconductors.Thyristor (on the right) shall be updated, too.

image

@dietmarw
Copy link
Member Author

@christiankral Good point. I've corrected the semiconductor icon and also adjusted the position of the firing connection so it looks equally now:

image

@dietmarw
Copy link
Member Author

I did not touch the position of the name as this is not as per User's Guide anyway and would require a total overhaul of all components and is probably not worth it for these existing elements.

@christiankral christiankral self-requested a review October 29, 2019 15:37
christiankral
christiankral approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@beutlich beutlich removed the request for review from AHaumer October 29, 2019 18:42
@beutlich beutlich merged commit 7a963bc into modelica:master Oct 29, 2019
@dietmarw dietmarw deleted the t3165-trigger branch November 5, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiankral christiankral christiankral approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@dietmarw dietmarw

Labels
L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Wrong position of fire input in GTO
3 participants
@dietmarw @christiankral @beutlich