-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge HeatingNPN/HeatingPNP with NPN/PNP #3178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
I noticed that the manual conversion is slightly smarter than the automatic one in that useHeatPort=true is removed, but I don't see how we could handle that without an extension of the conversion - and I don't think that extension is worth the effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I tested the conversion script
- I tested the examples
Modelica.Electrical.Analog.Examples.HeatingNPN_NORGate
andModelica.Electrical.Analog.Examples.HeatingPNP_NORGate
- I tested the old MSL 3.2.3 heating bipolar transistor models against the new models with non-default parameters
- I checked the code
I found no discrepancy, so the PR is OK from my side
I thought that removing modifiers already is possible, see for example Lines 419 to 422 in 7a963bc
|
I was unclear: removing |
This is the last missing conversion to finally close #2899.