Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation and description strings to Modelica.Fluid.Dissipation.Utilities.Functions.General.{CubicInterpolation_lambda, CubicInterpolation_Re} #3185

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Add documentation and description strings to Modelica.Fluid.Dissipation.Utilities.Functions.General.{CubicInterpolation_lambda, CubicInterpolation_Re} #3185

merged 1 commit into from
Nov 18, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Oct 30, 2019 •
edited

  • Improve description comments and documentation
  • Add the alternative implementation using Modelica.Fluid.Utilities.cubicHermite at least as comment
  • Change the integer literal 1 to yd1 (to make the current optimized formula more explicit)

resolves #2972

@beutlich beutlich added L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation documentation Issue addresses the documentation labels Oct 30, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Oct 30, 2019
@beutlich beutlich self-assigned this Oct 30, 2019
@beutlich beutlich requested review from thorade and removed request for thorade November 6, 2019 07:56
@beutlich
Copy link
Member Author

@MartinOtter @thorade @wischhusen Please add your review to unblock the merge.

thorade
thorade approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@thorade thorade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

equations/algorithms unchanged

@beutlich beutlich merged commit 99baa1a into modelica:master Nov 18, 2019
@beutlich beutlich deleted the add-doc branch November 18, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw approved these changes

@thorade thorade thorade approved these changes

Assignees

@beutlich beutlich

Labels
documentation Issue addresses the documentation L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Cubic interpolation Moody diagram
3 participants
@beutlich @dietmarw @thorade