-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation of AronSensor #3186
Conversation
Proposed the following documentation changes: 1) removed reference to the need to have sinusoidal voltages and currents (Aron sensor works with any shape of voltages and currents) 2) added basic explanation of the Aron connection and a reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML Tags are not balanced.
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
I would very much appreciate @AHaumer review here as he agreed to make a review and as this PR modifies the documentation of the model he developed. |
Proposal to get reference in line with MSL guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct:
This device works only for in three-phase systems without neutral.
We could add:
In case of a three-phase system without neutral (i.e. the sum of the three currrents is zero) ...
@max-privato Please correct the typo: Just one short summary (that would be sufficient for documenation - and much mor concise!): |
Typo corrected.
Info can be more detailed or more concise. I proposed a rather detailed description because I was asked to add some biblio reference. Adding a reference discussing the Aron connection seemed to me overkill. I preferred an in-model description of it that, being in competition with a biblio reference, must be detailed and precise enough. For me, both solutions (I mean AHaumer's and mine) are good enough. I leave to the Library managers the final choice. |
@AHaumer @christiankral What is left to do here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me the documentation is fine now.
to be equivalent with the Analog implementation
@max-privato please merge https://github.com/max-privato/ModelicaStandardLibrary/pull/2 so that we have the same documentation in the Analog and QuasiStatic.SinglePhase package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for merging https://github.com/max-privato/ModelicaStandardLibrary/pull/2
One more note: the Aron sensor could also be extended so that it works with an arbitrary number of phases, considering that there is no neutral connected. So the limitation to |
Aron sensor documentation for quasi stastic domain
Proposed the following documentation changes: