Make the SimpleTriac model extend from conditional heatport model like the rest #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
added
the
L: Electrical.Analog
dietmarw
changed the title
|
This should be merged after #3183 |
Also fixed a couple of connector positions and cleaned up the appearance of the SimpleTriac model
beutlich
force-pushed
the
ExtendHeatport
branch
from
11b2371
to
deaf025
Compare
JoeRiel
approved these changes
Nov 2, 2019
beutlich
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleTriac was the only model in the Semiconductors package that did not extend from the conditionalHeatport model for some unknown reason. This fixes this.
In addition some of the connectors were awkwardly placed inside this package.