Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description comments to arguments of "built-in" mathematical functions #3194

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Add description comments to arguments of "built-in" mathematical functions #3194

merged 1 commit into from
Nov 4, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Nov 2, 2019

This question on SO revealed that the arguments of the Math functions lack a description comment.

@beutlich beutlich added the L: Math Issue addresses Modelica.Math label Nov 2, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Nov 2, 2019
@beutlich beutlich self-assigned this Nov 2, 2019
thorade
thorade approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@thorade thorade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only unsure about the two log functions.

@beutlich
Copy link
Member Author

beutlich commented Nov 2, 2019

Can use log and log10 if you prefer.

HansOlsson
HansOlsson approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I guess. Even though a bit excessive.

@beutlich beutlich merged commit f7a4580 into modelica:master Nov 4, 2019
@beutlich beutlich deleted the add-comments-builtin branch November 4, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorade thorade thorade approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
L: Math Issue addresses Modelica.Math
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beutlich @thorade @HansOlsson