-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve icon and documentation of ElectroMagneticConverter #3220
Conversation
Ampere's law relates the terms magnetomotive force and magnetic voltage. This is a similar situation as with the relation of the electromotive force and the electric voltage in Kirchhoff's law. With these terms the two laws are:
Modelica can neither treat magnetomotive nor electromotive forces directly in interconnected equivalent circuits. Instead the two laws are applied in a different way:
Therefore each magnetomotive and electromotive is converted into an equivalent magnetic and electric voltage, respectively. In a magnetic circuit the electromotive force Therefore, there exists a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new blue arrow from the screenshot above looks odd to me (and is easy to miss). Do we have any references showing such diagrams? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have doubts about the documentation using the term "Kirchhoffs laws". The Kirchhoffs laws are well known from the voltage and current laws, not like they are used here. Even if there exist quotations like this it may confuse the users (see what appears if you google "modelica kirchhoff").
@HansOlsson |
@DrMartinKuhn |
Sorry, I still have my problems with the inter-domain E=sum(v). Six lines below there is 0=sum(v) without visual change of variables. |
My main concern was that we shouldn't try to invent some new graphical representation for this, but reuse what others do. To me there are two related issues with the design:
An alternative (used for transformers in many places - including Modelica.Electrical as I recall) is to not have arrows at all. |
One additional problem in the icon (old and new) is the direction of the V_m arrow. It follows the German VZS (Verbraucherzählpfeilsystem) where voltage arrows always point from |
Considering the comments of Hans and Dietmar I propose to delete all arrows. For the proposed documentation, I have the feeling it does not improve the understanding but it is contradictory in some parts. Furthermore it tries to introduce a left or right hand system - while there was never defined any coiling direction in the original component and in the end it is all about definition since we transfer a 2D system to 1D. Therefore I propose to leave the old documentation and extend it by |
I agree to remove all arrows. |
As of the icon, some suggestions and thoughts:
which is a purely German thing. As the magnetic voltage caused by the electric currents is a magnetic voltage source it may make sense to indicate it as a magnetic voltage source.
|
Ok @christiankral is correct: We have a definition of positive directions of voltage, current, mmf resp. magnetic potential difference and flux - there's no need for arrows. |
Since the images contain text this becomes more important when we want to support modelica/ModelicaSpecification#302 |
Hm, it's only letters, right? I do not think that we need to translate images in first place. Might be rather related to modelica/ModelicaSpecification#546. |
How do we proceed with that PR? |
Independent on any SVG support it would still be nice to have the sources of the images in the repository. Could you add them? |
@dietmarw The currently used image and the source IPE file are stored at https://gitlab.com/christiankral/ModelicaImages/tree/master/ModelicaImages/Magnetic/FluxTubes/Basic/ElectroMagneticConverter Shall we copy the IPE file to the folder |
@christiankral Yes having the source files in the same location and same name (except the extension of course) makes it easy to find and edit at a later point in time. |
Should we add them as
|
Yes, that might be a good idea. @christiankral I suggest you add the IPE sources in |
@beutlich Hope these ppt are avialable as pdf, too. |
Yes, there are Modelica/Resources/Documentation/Clocked/Modelica_Synchronous.pdf and Modelica/Resources/Documentation/Fluid/Stream-Connectors-Overview-Rationale.pdf. File Modelica/Resources/Documentation/Mechanics/Figure_PlanarLoopAnalytic.ppt is only used to draw the figures, thus there is no PDF required here. |
Please be aware, that I rebased the PR branch and resolved the merge conflict. |
The Ampere's Law image contains texts - not just single letters; and that raises the issue of translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the image source files to the export-ignore list. As for the translation since the image is part of the documentation than a documentation in a different language would simply have to come up with a different image if needed. In my eyes no need to hold off this PR because of that.
I agree with the conclusion. It was just that it implies that when translating we also need to consider this - e.g., allow different images for different languages, or revisit that part of the PR. |
…(FluxTubes and QuasiStatic.FluxTubes)
Refers to #3218:
improve icon (reference arrows) and documentation (include a hint about right-hand screw rule) of ElectroMagneticConverter