-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automaticLocalSeed in Math.Random and utilize in noise blocks #3224
Conversation
Two comments:
|
I guess it is the other way round as it was an unintended side-effect that the automatically generated local seed somehow depended on the number/order of noise blocks in the model. This is now circumvented in such a way that this automatically generated local seed only depends on the component name, no matter how many noise blocks are found in the model
True. See also #1957 (comment). I'll fix automaticLocalSeed to use the plain |
Ah, yes, I see - we have kept that possibility; just more predictably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
There was some in and out development going on in #1957 when the noise blocks and functions were introduced in MSL v3.2.2 with the automaticLocalSeed left to do. This pull request fixes #1861.
@akloeckner @dzimmer @fvanderlinden FYI