Add shapes HollowCylinderCircumferentialFlux and Toroid #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHaumer
added
enhancement
AHaumer
requested review from
dietmarw,
christiankral,
beutlich,
ThomasBoedrich and
DrMartinKuhn
beutlich
reviewed
Nov 25, 2019
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreAirgap.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreAirgap.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreQuadraticCrossSection.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreQuadraticCrossSection.mo
Outdated
Show resolved
Hide resolved
|
I know, this is about the example, but could you please confirm the correct layout of the toroid? |
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreAirgap.mo
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreAirgap.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreAirgap.mo
Outdated
Show resolved
Hide resolved
…eAirgap.mo Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
…eAirgap.mo Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
…eQuadraticCrossSection.mo Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
…eQuadraticCrossSection.mo Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
|
Why has this PR been closed? |
…rcumferentialFlux.mo Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
…rcumferentialFlux.mo Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
|
Fixed the merge conflict in Modelica.Magnetic.FluxTubes.Icons va rebasing. This is how it Looks now:
|
|
@beutlich Thanks for fixing the merge conflict. Yes that's how they should look. We need one more approval for merging. |
|
@christiankral are all your change requests satisfied? |
dietmarw
previously requested changes
Dec 12, 2019
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreAirgap.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreQuadraticCrossSection.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Shapes/FixedShape/HollowCylinderCircumferentialFlux.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Shapes/FixedShape/HollowCylinderCircumferentialFlux.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Shapes/FixedShape/HollowCylinderCircumferentialFlux.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FluxTubes/Shapes/FixedShape/HollowCylinderCircumferentialFlux.mo
Outdated
Show resolved
Hide resolved
…eAirgap.mo Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
…eQuadraticCrossSection.mo Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
…rcumferentialFlux.mo Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
…rcumferentialFlux.mo Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
…rcumferentialFlux.mo Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
…dardLibrary into FluxTubes04NewShapes # Conflicts: # Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreAirgap.mo # Modelica/Magnetic/FluxTubes/Examples/BasicExamples/ToroidalCoreQuadraticCrossSection.mo # Modelica/Magnetic/FluxTubes/Icons/package.mo # Modelica/Magnetic/FluxTubes/Icons/package.order # Modelica/Magnetic/FluxTubes/Shapes/FixedShape/HollowCylinderCircumferentialFlux.mo # Modelica/Magnetic/FluxTubes/Shapes/FixedShape/Toroid.mo
…rcumferentialFlux.mo Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
christiankral
approved these changes
Dec 14, 2019
beutlich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to #3218:
added shape HollowCylinderCircumferentialFlux and a test example
added shape Toroid (with circular cross section) and a test example