-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize molar gas constant in Modelica.Media.Interfaces.{TemplateMedium, PartialLinearFluid}.BaseProperties #3228
Conversation
This would require reading the publication, because if a different value of the gas constant was used in the publication, it must also be used in the implementation to get matching results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I agree with @thorade here. Changes in Modelica/Media/package.mo make sense and should be implemented. However, for the R134a and Moist air reference cases, it is arguably wrong since this will cause the results to change. The R values should be considered fossilized/internal factors that you shouldn't care about externally. You either need two changes (two wrongs making a right) or no changes at all to keep it consistent with the publication. I would vote for the latter. |
@casella Acceptable for you? |
Absolutely! In fact, those models do not really need a value for R, it is only provided because the interface asks for it. I'm not sure why we put some rounded numbers, but I guess that was the reason. Please go ahead |
Utilize the molar gas constant
R
from Modelica.Constants instead of different approximations.