Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable coupling factor k=1 in K_CoupledInductors #3230

Merged
merged 1 commit into from
Dec 1, 2019
Merged

Enable coupling factor k=1 in K_CoupledInductors #3230

merged 1 commit into from
Dec 1, 2019

Conversation

beutlich
Copy link
Member

Closes #2775 and closes #2796 as proposed.

@beutlich beutlich added enhancement New feature or enhancement L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 labels Nov 13, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Nov 13, 2019
@beutlich beutlich self-assigned this Nov 13, 2019
@beutlich beutlich changed the title Enable coupling factor k=1 in C_Capacitor Enable coupling factor k=1 in K_CoupledInductors Nov 13, 2019
HansOlsson
HansOlsson approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Although it might be good to add a test-case specifically for this.

AHaumer
AHaumer approved these changes Dec 1, 2019
View reviewed changes
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me

@beutlich beutlich merged commit ab27b20 into modelica:master Dec 1, 2019
@beutlich beutlich deleted the enable-k-1 branch December 1, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AHaumer AHaumer AHaumer approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
enhancement New feature or enhancement L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3
Projects
None yet
Milestone
MSL4.0.0
3 participants
@beutlich @AHaumer @HansOlsson