Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify case with one coefficient and one variable in Modelica.Electrical.Spice3.Additionals.poly #3233

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

beutlich
Copy link
Member

Only for one coefficient and one variable the polynomial is evaluated as linear function (with vanishing absolute term).

Closes #2794.

Only for one coefficient and one variable the polynomial is evaluated as linear function (with vanishing absolute term).
@beutlich beutlich added the L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 label Nov 14, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Nov 14, 2019
@beutlich beutlich self-assigned this Nov 14, 2019
@beutlich beutlich changed the title Fix case with one coefficient and one variable in Modelica.Electrical.Spice3.Additionals.poly Specify case with one coefficient and one variable in Modelica.Electrical.Spice3.Additionals.poly Nov 14, 2019
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, but since it is so weird it would be helpful with additional documentation:
E.g. https://www.macspice.com/ug/secC.html explains the special case as:

Note: if the polynomial is one-dimensional and exactly one coefficient is specified, then SPICE assumes it to be p1 (and p0 = 0.0), in order to facilitate the input of linear controlled sources.

@beutlich
Copy link
Member Author

beutlich commented Dec 2, 2019

Looks correct, but since it is so weird it would be helpful with additional documentation:
E.g. https://www.macspice.com/ug/secC.html explains the special case as:

Note: if the polynomial is one-dimensional and exactly one coefficient is specified, then SPICE assumes it to be p1 (and p0 = 0.0), in order to facilitate the input of linear controlled sources.

Yes, agreed. I just was not sure which Spice source we should cite here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spice3 poly source
3 participants