New example differential amplifier #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHaumer
added
L: Electrical.Analog
AHaumer
requested review from
dietmarw,
christiankral,
beutlich,
DrMartinKuhn and
christophclauss
|
I proposed some formal changes of the documentation. On my opinion the "one sentence = one paragraph" style shall be avoided. If the changes are accepted, I am fine with this PR. |
Co-Authored-By: Christian Kral <dr.christian.kral@gmail.com>
Co-Authored-By: Christian Kral <dr.christian.kral@gmail.com>
beutlich
reviewed
Dec 5, 2019
There was a problem hiding this comment.
- Tested that it runs in SimuationX and Dymola checks it without errors.
- Not sure if DifferentialAmplifierData really belongs to Modelica.Electrical.Analog.Examples.OpAmps.OpAmpCircuits. I'd prefer to have it as local record type definition within the example model.
- Should we rename NonInvertingAmp to NonInvertingAmplifier for consistency? Similarly for InvertingAmp.
beutlich
previously requested changes
Dec 5, 2019
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
…delicaStandardLibrary into DifferentialAmplifier
dietmarw
reviewed
Dec 11, 2019
|
@dietmarw : done |
dietmarw
approved these changes
Dec 12, 2019
christiankral
approved these changes
Dec 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented an example of a differential amplifier for measurement.