Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate ParameterDefaults #3256

Merged
merged 3 commits into from
Dec 21, 2019
Merged

Relocate ParameterDefaults #3256

merged 3 commits into from
Dec 21, 2019

Conversation

christiankral
Copy link
Contributor

@christiankral christiankral commented Dec 7, 2019 •
edited by beutlich

Move UsersGuide.ParameterDefaults to Modelica.UsersGuide.Conventions.ModelicaCode; fix #3248

@christiankral christiankral added this to the MSL4.0.0 milestone Dec 7, 2019
tobolar
tobolar approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

beutlich
beutlich reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is conversion required after all?

@beutlich beutlich added documentation Issue addresses the documentation L: UsersGuide Issue addresses Modelica.UsersGuide task General work that is not related to a bug or feature labels Dec 10, 2019
@beutlich beutlich merged commit 7aa4997 into modelica:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobolar tobolar tobolar approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@beutlich beutlich

Labels
documentation Issue addresses the documentation L: UsersGuide Issue addresses Modelica.UsersGuide task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Relocate UsersGuide.ParameterDefaults
3 participants
@christiankral @tobolar @beutlich