Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix waitTime visualization in transition icons #3258

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Fix waitTime visualization in transition icons #3258

merged 1 commit into from
Dec 11, 2019

Conversation

beutlich
Copy link
Member

No description provided.

@beutlich beutlich added L: StateGraph Issue addresses Modelica.StateGraph P: low Low priority issue labels Dec 10, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Dec 10, 2019
@beutlich beutlich self-assigned this Dec 10, 2019
HansOlsson
HansOlsson reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be visible=DynamicSelect(true, enableTimer)?

@beutlich
Copy link
Member Author

enableTimer is a parameter, thus there is no much dynamic behaviour during simulation.

HansOlsson
HansOlsson approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@beutlich beutlich merged commit bcc8290 into modelica:master Dec 11, 2019
@beutlich beutlich deleted the fix-waitTime-visualization-in-transition-icons branch December 11, 2019 16:18
@beutlich beutlich added the icon Issues addresses the icon graphics label Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
icon Issues addresses the icon graphics L: StateGraph Issue addresses Modelica.StateGraph P: low Low priority issue
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beutlich @dietmarw @HansOlsson