Add/fix description comments in Fluid #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
approved these changes
Dec 21, 2019
beutlich
force-pushed
the
fix-param-comments
branch
from
432a2fd
to
7156930
Compare
|
@casella OK for you? |
thorade
reviewed
Jan 6, 2020
| annotation (Placement(transformation( | ||
| extent={{-20,0},{20,-10}}, | ||
| origin={0,-100}))); | ||
|
|
||
| // Heat transfer through boundary | ||
| parameter Boolean use_HeatTransfer = false | ||
| "= true to use the HeatTransfer model" | ||
| "= true, if HeatTransfer model is used" |
There was a problem hiding this comment.
I think I liked the previous version of this comment better
thorade
approved these changes
Jan 6, 2020
|
For the record, I think this is really no big deal 😃 |
|
If it's fine for @thorade, it's fine for me 😃 Sorry, but I took two weeks off for the Christmas break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the remaining parameter descriptions to finally resolve #2636.