Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IdealTriacCircuit example #3284

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Fix IdealTriacCircuit example #3284

merged 1 commit into from
Dec 23, 2019

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Dec 22, 2019 •
edited by beutlich

Should resolve #3283

@AHaumer AHaumer added bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog example Issue only addresses example(s) labels Dec 22, 2019
@AHaumer AHaumer added this to the MSL4.0.0 milestone Dec 22, 2019
@AHaumer AHaumer self-assigned this Dec 22, 2019
@AHaumer AHaumer mentioned this pull request Dec 22, 2019
Closed
@beutlich beutlich changed the title fixes #3283 Fix IdealTriacCircuit example Dec 23, 2019
JoeRiel
JoeRiel approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@JoeRiel JoeRiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs fine here (on MapleSim). A trapezoid current source seems the simplest fix.

@beutlich beutlich merged commit 4f50665 into modelica:master Dec 23, 2019
@AHaumer AHaumer deleted the SimpleTriacCircuit3283 branch December 30, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRiel JoeRiel JoeRiel approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@AHaumer AHaumer

Labels
bug Critical/severe issue example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Modelica.Electrical.Analog.Examples.SimpleTriacCircuit flawed
3 participants
@AHaumer @JoeRiel @beutlich