Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batteries extensions #3289

Merged
merged 17 commits into from
Jan 16, 2020
Merged

Batteries extensions #3289

merged 17 commits into from
Jan 16, 2020

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Dec 24, 2019

As mentioned in #3285 I've implemented some extensions to Batteries (based on #3285):
cells and stacks equipped with sensors
stacks built as Ns x Np matric of different cells
Thus, one is able to investigate the influence of a degraded cell on the bahviour of the whole stacks. as well as to design a battery management system.
For active cell balancing, the stack models have to get equipped additionally with appropriate actors.

@AHaumer AHaumer added enhancement New feature or enhancement L: Electrical.Batteries Issue addresses Modelica.Electrical.Batteries labels Dec 24, 2019
@AHaumer AHaumer added this to the MSL4.0.0 milestone Dec 24, 2019
@AHaumer AHaumer self-assigned this Dec 24, 2019
@beutlich beutlich removed their request for review January 4, 2020 10:50
dietmarw
dietmarw previously approved these changes Jan 8, 2020
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong PR.

@dietmarw dietmarw self-requested a review January 8, 2020 16:31
@casella
Copy link
Contributor

casella commented Jan 9, 2020

I'll take care of this ASAP, I guess it will take some time to do a proper evaluation

@beutlich
Copy link
Member

I resolved the pseudo merge conflicts and rebased the branch.

@claassistantio
Copy link

claassistantio commented Jan 14, 2020

CLA assistant check
All committers have signed the CLA.

@christiankral
Copy link
Contributor

I changed variable name p to power in 91702ff and c0ad183 to be in line with the usual naming convention of the Electrical domain.

@AHaumer I wonder if we shall also change the variable name losses to lossPower or LossPower to avoid an additional variable name for a loss term.

@AHaumer
Copy link
Contributor Author

AHaumer commented Jan 14, 2020

@christiankral you're right with losses vs. lossPower

@AHaumer
Copy link
Contributor Author

AHaumer commented Jan 14, 2020

@christiankral
followed your advice and renamed losses to lossPower
resolved the bug introduced by renaming p to power (we have to correct the conntection to the bus variable, too - no error message since new bus variable p is introduced)

@dietmarw dietmarw merged commit b29459c into modelica:master Jan 16, 2020
@dietmarw dietmarw assigned dietmarw and unassigned AHaumer Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement L: Electrical.Batteries Issue addresses Modelica.Electrical.Batteries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants