Normalize inputs to from_nxy and from_nxz #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
added
bug
MartinOtter
approved these changes
Jan 9, 2020
MartinOtter
added
enhancement
|
I changed the label from bug to enhancement, because this pull request improves the numerics (the original code is correct, but, as any other code, may fail due to numerical issues). |
OK. That implies that I won't back-port the changes to maint/3.2.3. |
tobolar
reviewed
Jan 9, 2020
tobolar
reviewed
Jan 9, 2020
|
|
tobolar
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3201