Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid code duplication of functions g2, cond_dT and visc_dTp in Modelica.Media.Air.ReferenceMoistAir.Utilities.IF97_new #3296

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Avoid code duplication of functions g2, cond_dT and visc_dTp in Modelica.Media.Air.ReferenceMoistAir.Utilities.IF97_new #3296

merged 2 commits into from
Jan 10, 2020

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Jan 8, 2020

Avoid code duplication of functions g2, cond_dT and visc_dTp by introduction of short-class functions in Modelica.Media.Air.ReferenceMoistAir.Utilities.IF97_new.

I checked that all 7 example models of Modelica.Media.Examples.ReferenceAir still give identical results.

As reported by #3060 (comment).

@beutlich
refs modelica#3060: Avoid code duplication
df118a6 
Avoid code duplication of functions g2, cond_dT and visc_dTp by introduction of short-class functions in Modelica.Media.Air.ReferenceMoistAir.Utilities.IF97_new
@beutlich beutlich added L: Media Issue addresses Modelica.Media task General work that is not related to a bug or feature labels Jan 8, 2020
@beutlich beutlich self-assigned this Jan 8, 2020
@beutlich beutlich mentioned this pull request Jan 8, 2020
Open
@beutlich
Copy link
Member Author

beutlich commented Jan 8, 2020

@MartinOtter I added you as reviewer since you added the IF97_new package by ba2f041.

@beutlich beutlich added this to the MSL4.0.0 milestone Jan 8, 2020
@HansOlsson
Copy link
Contributor

Shouldn't it be "final p=0, final phase=0" as well as "final checkLimits=false"?

@MartinOtter
Copy link
Member

@MartinOtter I added you as reviewer since you added the IF97_new package by ba2f041.

I only included this package into the MSL. The package was developed by LTX Simulation GmbH. Therefore, I suggest that @wischhusen should approve this change

@MartinOtter MartinOtter removed their request for review January 9, 2020 09:53
@wischhusen
Copy link
Contributor

Makes sense to me. I did not find obstacles, because the calculation is now equivalent to the state we had after the first release of ReferenceMoistAir.

@beutlich
Copy link
Member Author

Makes sense to me. I did not find obstacles, because the calculation is now equivalent to the state we had after the first release of ReferenceMoistAir.

@wischhusen Can you approve (or reject) the PR then since we require a second review. Thanks.

wischhusen
wischhusen approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@wischhusen wischhusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@wischhusen wischhusen merged commit a34f57c into modelica:master Jan 10, 2020
@beutlich beutlich deleted the update-workaround-package branch January 10, 2020 11:30
@beutlich beutlich assigned wischhusen and unassigned beutlich Jan 10, 2020
@beutlich
Copy link
Member Author

Thanks, perfect timing 😃

grafik

@wischhusen
Copy link
Contributor

Jippieh :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorade thorade thorade approved these changes

@wischhusen wischhusen wischhusen approved these changes

Assignees

@wischhusen wischhusen

Labels
L: Media Issue addresses Modelica.Media task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@beutlich @HansOlsson @MartinOtter @wischhusen @thorade