Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of QuadraticCoreAirgap #3315

Merged

Conversation

christiankral
Copy link
Contributor

In #3307 a leakage model was added in parallel to the air gap (and coil) model:

image

Therefore the included image does not match the model as it does not include the leakage effect:

image

In addition to that the table and the text do not match the model any more:

image

I made an attempt to fix some parts of the documentation. The following issues are still missing:

  • @AHaumer Please update the sketch which shows only one dashed line going straight through the airgap
  • The included table does currently not show the leakage path as it has not "real" area of cross section and length; @AHaumer I wonder if can somehow overcome this problem or just leave the table as it is

@christiankral christiankral added L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes documentation Issue addresses the documentation labels Jan 14, 2020
@christiankral christiankral added this to the MSL4.0.0 milestone Jan 14, 2020
christiankral and others added 2 commits January 14, 2020 17:44
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
@christiankral
Copy link
Contributor Author

@beutlich Thanks for fixing these issues
By the way: I like Markdown a lot more than HTML ...

@beutlich
Copy link
Member

By the way: I like Markdown a lot more than HTML ...

Luckily we have HTML Tidy now running through Travis CI.

Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that ...

@dietmarw
Copy link
Member

@AHaumer There are still the things missing that @christiankral mentioned above. Can you provide the updated sketches and table?

@AHaumer
Copy link
Contributor

AHaumer commented Jan 15, 2020

@dietmarw
Thanks to @christiankral - he has updated the table already!
I tried to update the sketch accordingly.

@AHaumer AHaumer marked this pull request as ready for review January 15, 2020 17:55
@beutlich beutlich removed their request for review January 15, 2020 20:18
@beutlich beutlich assigned dietmarw and unassigned beutlich Jan 15, 2020
@dietmarw dietmarw merged commit 73d021f into modelica:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue addresses the documentation L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants