Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced explicit syntax sections with link to Modelica Grammar #3321

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Replaced explicit syntax sections with link to Modelica Grammar #3321

merged 1 commit into from
Feb 24, 2020

Conversation

dietmarw
Copy link
Member

@dietmarw dietmarw commented Jan 15, 2020 •
edited

Ref #2820

@dietmarw dietmarw self-assigned this Jan 15, 2020
@dietmarw dietmarw added the L: ModelicaReference Issue addresses ModelicaReference label Jan 15, 2020
@dietmarw dietmarw added this to the MSL4.0.0 milestone Jan 15, 2020
HansOlsson
HansOlsson approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Note that the removed "See Modelica Language Specification for further details" are in syntax-sections and ModelicaReference.ModelicaGrammar should contain all of that.

@beutlich
Copy link
Member

I believe #2820 (comment) is not yet resolved. Thus, #2820 should not yet closed.

@dietmarw
Copy link
Member Author

That's true. I missed that. @HansOlsson could you add those to this PR. I think as short a description as possible would suffice.

@beutlich beutlich changed the title Fixes #2820: Replaced explicit syntax section with link Modelica Grammar Fixes #2820: Replaced explicit syntax sections with link to Modelica Grammar Jan 15, 2020
@beutlich
Copy link
Member

That's true. I missed that. @HansOlsson could you add those to this PR. I think as short a description as possible would suffice.

@HansOlsson Can you please add the sections on synchronous language elements. Thanks.

@HansOlsson
Copy link
Contributor

That's true. I missed that. @HansOlsson could you add those to this PR. I think as short a description as possible would suffice.

@HansOlsson Can you please add the sections on synchronous language elements. Thanks.

I tried to do that in #3443
Obviously one could add more.

@dietmarw dietmarw changed the title Fixes #2820: Replaced explicit syntax sections with link to Modelica Grammar Replaced explicit syntax sections with link to Modelica Grammar Feb 24, 2020
@beutlich beutlich force-pushed the t2820-UpdateModelicaReference branch from de3a87d to e6f446c Compare February 24, 2020 19:30
@beutlich beutlich force-pushed the t2820-UpdateModelicaReference branch from e6f446c to a71ffd9 Compare February 24, 2020 19:31
@beutlich beutlich assigned beutlich and unassigned dietmarw and HansOlsson Feb 24, 2020
@beutlich beutlich added the documentation Issue addresses the documentation label Feb 24, 2020
@beutlich beutlich merged commit 86d73b0 into modelica:master Feb 24, 2020
@dietmarw dietmarw deleted the t2820-UpdateModelicaReference branch February 26, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@beutlich beutlich

Labels
documentation Issue addresses the documentation L: ModelicaReference Issue addresses ModelicaReference
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dietmarw @beutlich @HansOlsson