Add missing quasi-static FluxTubes models #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiankral
added
enhancement
beutlich
reviewed
Jan 15, 2020
There was a problem hiding this comment.
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\QuadraticCoreAirgap.mo": line 141 column 1 - Info: value for attribute "border" missing quote marks (MISSING_QUOTEMARK_OPEN)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\QuadraticCoreAirgap.mo": line 141 column 1 - Info: value for attribute "cellspacing" missing quote marks (MISSING_QUOTEMARK_OPEN)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\QuadraticCoreAirgap.mo": line 141 column 1 - Info: value for attribute "cellpadding" missing quote marks (MISSING_QUOTEMARK_OPEN)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\QuadraticCoreAirgap.mo": line 157 column 1 - Warning: trimming empty <p> (TRIM_EMPTY_ELEMENT)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\ToroidalCoreAirgap.mo": line 102 column 1 - Info: value for attribute "border" missing quote marks (MISSING_QUOTEMARK_OPEN)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\ToroidalCoreAirgap.mo": line 102 column 1 - Info: value for attribute "cellspacing" missing quote marks (MISSING_QUOTEMARK_OPEN)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\ToroidalCoreAirgap.mo": line 102 column 1 - Info: value for attribute "cellpadding" missing quote marks (MISSING_QUOTEMARK_OPEN)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\ToroidalCoreQuadraticCrossSection.mo": line 101 column 1 - Info: value for attribute "border" missing quote marks (MISSING_QUOTEMARK_OPEN)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\ToroidalCoreQuadraticCrossSection.mo": line 101 column 1 - Info: value for attribute "cellspacing" missing quote marks (MISSING_QUOTEMARK_OPEN)
File ".\Modelica\Magnetic\QuasiStatic\FluxTubes\Examples\BasicExamples\ToroidalCoreQuadraticCrossSection.mo": line 101 column 1 - Info: value for attribute "cellpadding" missing quote marks (MISSING_QUOTEMARK_OPEN)
Merged
|
@christiankral From the Travis CI (see link below on the failing test too): |
|
@christiankral Basically you forgot to escape the quotes. |
Yes indeed! I definitely did not think of escaping the quotes. Thanks. I will fix it. |
of the models introduced by this PR (so no separate PR is required)
|
Is this related to #3218? |
dietmarw
reviewed
Jan 16, 2020
Modelica/Magnetic/QuasiStatic/FluxTubes/Examples/BasicExamples/package.mo
Outdated
Show resolved
Hide resolved
Co-Authored-By: Dietmar Winkler <dietmar.winkler@dwe.no>
AHaumer
approved these changes
Jan 17, 2020
beutlich
changed the title
dietmarw
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Magnetic.FluxTubes library contains some fixed shape models which have been forgotten to be implemented in the quasi static FluxTubes library. This PR provides the missing models and the "same" examples implemented in Magnetic.FluxTubes.Examples.