-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the non-linear case from doc strings #3328
Merged
beutlich
merged 5 commits into
modelica:master
from
christiankral:fix-QuasiStatic-FluxTubes-documentation
Jan 17, 2020
Merged
Removing the non-linear case from doc strings #3328
beutlich
merged 5 commits into
modelica:master
from
christiankral:fix-QuasiStatic-FluxTubes-documentation
Jan 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiankral
added
L: Magnetic.QuasiStatic
Issue addresses Modelica.Magnetic.QuasiStatic
documentation
Issue addresses the documentation
labels
Jan 16, 2020
beutlich
reviewed
Jan 16, 2020
Modelica/Magnetic/QuasiStatic/FluxTubes/Shapes/FixedShape/Cuboid.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/QuasiStatic/FluxTubes/Shapes/FixedShape/GenericFluxTube.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/QuasiStatic/FluxTubes/Shapes/FixedShape/HollowCylinderAxialFlux.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/QuasiStatic/FluxTubes/Shapes/FixedShape/HollowCylinderRadialFlux.mo
Outdated
Show resolved
Hide resolved
AHaumer
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for me.
I can approve once @beutlich 's suggestions are accepted. |
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
dietmarw
approved these changes
Jan 17, 2020
beutlich
reviewed
Jan 17, 2020
Modelica/Magnetic/QuasiStatic/FluxTubes/Shapes/FixedShape/HollowCylinderRadialFlux.mo
Outdated
Show resolved
Hide resolved
beutlich
reviewed
Jan 17, 2020
Modelica/Magnetic/QuasiStatic/FluxTubes/Shapes/FixedShape/HollowCylinderRadialFlux.mo
Outdated
Show resolved
Hide resolved
Co-Authored-By: Thomas Beutlich <modelica@tbeu.de>
beutlich
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Issue addresses the documentation
L: Magnetic.QuasiStatic
Issue addresses Modelica.Magnetic.QuasiStatic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some wrong documentation of the
QuasiStatic.FluxTubes
library, which was introduced by copy + paste errors when creating this library.