Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for-loop variable in quasi-static MutualInductor #3343

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Fix for-loop variable in quasi-static MutualInductor #3343

merged 1 commit into from
Jan 17, 2020

Conversation

christiankral
Copy link
Contributor

@christiankral christiankral commented Jan 17, 2020 •
edited by beutlich

Resolves #3342.

@christiankral christiankral added bug Critical/severe issue L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic labels Jan 17, 2020
@christiankral christiankral added this to the MSL4.0.0 milestone Jan 17, 2020
svorkoetter
svorkoetter approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@svorkoetter svorkoetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but I tend to avoid using l as a variable name since it looks too much like 1 and/or I in many so-called programming fonts.

@beutlich beutlich merged commit d5ae3a5 into modelica:master Jan 17, 2020
@beutlich beutlich changed the title Fix bug in quasi static MutualInductor Fix bug in quasi-static MutualInductor Jan 17, 2020
@beutlich beutlich mentioned this pull request Jan 17, 2020
Merged
@beutlich beutlich changed the title Fix bug in quasi-static MutualInductor Fix for-loop variable in quasi-static MutualInductor Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beutlich beutlich beutlich approved these changes

@svorkoetter svorkoetter svorkoetter approved these changes

Assignees

@beutlich beutlich

Labels
bug Critical/severe issue L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Bug in Modelica.Electrical.QuasiStationary.Multiphase.Basic.MutualInductor?
3 participants
@christiankral @beutlich @svorkoetter