Rename sensor outputs #3351
Merged
Rename sensor outputs #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiankral
added
the
L: Electrical.QuasiStatic
|
I see potential merge conflicts: Renaming sensor outputs will likely require to update the comparisonSignals.txt files as part of #3348, too. Thus, whichever PR gets merged first ... |
dietmarw
reviewed
Jan 21, 2020
Modelica/Electrical/QuasiStatic/Polyphase/Sensors/CurrentQuasiRMSSensor.mo
Show resolved
Hide resolved
dietmarw
requested changes
Jan 21, 2020
beutlich
reviewed
Jan 21, 2020
Modelica/Resources/Scripts/Conversion/ConvertModelica_from_3.2.3_to_4.0.0.mos
Outdated
Show resolved
Hide resolved
dietmarw
approved these changes
Jan 21, 2020
already considered in conversion script
beutlich
force-pushed
the
rename-sensor-output
branch
from
89fbf24
to
ac7b755
Compare
beutlich
approved these changes
Jan 21, 2020
beutlich
added a commit
that referenced
this pull request
Jan 21, 2020
beutlich
added a commit
that referenced
this pull request
Jan 22, 2020
christiankral
added a commit
to christiankral/ModelicaStandardLibrary
that referenced
this pull request
Mar 10, 2020
beutlich
pushed a commit
to beutlich/ModelicaStandardLibrary
that referenced
this pull request
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #3022. The following changes are applied both in
QuasiStatic.SinglePhaseandQuasiStatic.Polyphase:ifor current sensor)TwoPinElementarywith connectors but without declaration of voltage and currentRelativeSensorElementaryto be used with voltage and current sensor(s only)RelativeSensortoObsoleteModelica4.moas these models have only been used for voltage and current sensors; so there is no need to keep themModelicaTestConversion4.mo