Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce result file size of FFT examples (#3349) #3352

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Reduce result file size of FFT examples (#3349) #3352

merged 3 commits into from
Jan 20, 2020

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Jan 20, 2020 •
edited by beutlich

I reduced stop time, adding some hints in the documentation about maximum frequency, frequency resolution, sample time and sample period.
If needed, we could try some HideResult=true annotations additionally.

Resolves #3349.

@claassistantio
Copy link

claassistantio commented Jan 20, 2020 •
edited

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tobolar
❌ Anton Haumer

Anton Haumer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AHaumer AHaumer added enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks labels Jan 20, 2020
@AHaumer AHaumer requested a review from tobolar January 20, 2020 12:40
@AHaumer AHaumer added this to the MSL4.0.0 milestone Jan 20, 2020
@AHaumer AHaumer added the P: low Low priority issue label Jan 20, 2020
beutlich
beutlich approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reducing the simulation time by factor 10, the result files are disproportionately smaller.

Rectifier12pulseFFT.mat	182,71 M	20.01.2020 18:54	-a--
Rectifier6pulseFFT.mat	172,43 M	20.01.2020 18:52	-a--

@beutlich beutlich removed the request for review from dietmarw January 20, 2020 17:57
@beutlich beutlich added example Issue only addresses example(s) and removed enhancement New feature or enhancement labels Jan 20, 2020
@beutlich beutlich merged commit 119593d into modelica:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiankral christiankral christiankral approved these changes

@tobolar tobolar tobolar approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@beutlich beutlich

Labels
example Issue only addresses example(s) L: Blocks Issue addresses Modelica.Blocks P: low Low priority issue
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Immoderate size of simulation result data for Rectifier6pulseFFT and Rectifier12pulseFFT
6 participants
@AHaumer @claassistantio @christiankral @tobolar @beutlich @haa39214