Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consideration of pressure negligence for Modelica.Media.Incompressible.TableBased.T_ph #3402

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix consideration of pressure negligence for Modelica.Media.Incompressible.TableBased.T_ph #3402

merged 1 commit into from
Feb 12, 2020

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Feb 11, 2020 •
edited

Resolves #3399

I also removed the nonsensical annotation(Evaluate) from function argument densityOfT of h_pT.

@beutlich beutlich added bug Critical/severe issue L: Media Issue addresses Modelica.Media labels Feb 11, 2020
@beutlich beutlich added this to the MSL4.0.0 milestone Feb 11, 2020
@beutlich beutlich self-assigned this Feb 11, 2020
@beutlich beutlich added the P: high High priority issue label Feb 11, 2020
HansOlsson
HansOlsson approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@beutlich beutlich merged commit 88853de into modelica:master Feb 12, 2020
@beutlich beutlich deleted the fix-T_ph branch February 12, 2020 13:47
@beutlich beutlich mentioned this pull request Feb 12, 2020
Merged
@casella
Copy link
Contributor

casella commented Feb 12, 2020

I trust @thorade 's judgement here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorade thorade thorade approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
bug Critical/severe issue L: Media Issue addresses Modelica.Media P: high High priority issue
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Issues with Modelica.Media.Incompressible.TableBased.T_ph
4 participants
@beutlich @casella @thorade @HansOlsson