Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons of QuasiStatic.SinglePhase and QuasiStatic.Polyphase #3413

Merged
merged 9 commits into from
Feb 14, 2020

Conversation

christiankral
Copy link
Contributor

@christiankral christiankral commented Feb 13, 2020

Resolves #3354

This fix includes

  • location of %name
  • redundant %m
  • color of icons to match domain color
  • color of %m
  • location of slightly displaced connectors (most likely accidentally caused in previous commits)

@christiankral christiankral added enhancement New feature or enhancement L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic labels Feb 13, 2020
@christiankral christiankral added this to the MSL4.0.0 milestone Feb 13, 2020
@beutlich
Copy link
Member

beutlich commented Feb 13, 2020

@christiankral Can you please provide a before/after comparison screen shot for easier recognition. Thanks.

@christiankral
Copy link
Contributor Author

Pffff... I do understand your point, indeed, but it were one additional hour of work.

I tried to have a lots of small commits to better understand the changes.
Most changes are related to line colors:

  • {85,170,255} for complex signals
  • {0,0,127} for real signals

I guess it is sufficient to check for plausibility and coherence when just looking at the affected model icons: This should be a reasonable time effort as each model is stored in a separate file.

@beutlich would this comment possibly release me from providing the requested information?

@beutlich beutlich removed their request for review February 13, 2020 22:30
@beutlich beutlich added the icon Issues addresses the icon graphics label Feb 13, 2020
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine.

@beutlich beutlich removed the request for review from AHaumer February 14, 2020 19:30
@beutlich beutlich merged commit 72f5ed7 into modelica:master Feb 14, 2020
@beutlich beutlich removed the enhancement New feature or enhancement label Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon Issues addresses the icon graphics L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update icons of QuasiStatic.SinglePhase and QuasiStatic.Polyphase
3 participants