Fix initial conditions of Magnetic.FluxTubes hysteresis examples #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiankral
added
bug
|
@modelonrobinandersson for your information |
dietmarw
approved these changes
Feb 17, 2020
It depends. It is not the case if only an example is affected. It is the case if a library component is affected. And since this issue already is merged to maint/3.2.3 (and we usually only back-port bug-fixes) there is good reason to label it as bug. |
beutlich
approved these changes
Feb 23, 2020
beutlich
changed the title
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is related to #3409 and serves as equivalent PR to #3410 for (branch master) MSL 4.0.0.
In the three phase transformer model
protectedwas remove to access all the magnetic components from outside the model. Particularly, asprotectedis not needed and as the three phase transformer model is clearly intended to be used in the example only, this change is justified on my opinion.