-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed obsolete images from Resources/Fluid #3429
Conversation
Sorry but this is a total mess. What is it you actually wanted to achieve here? If you have a look what this PR touches (https://github.com/modelica/ModelicaStandardLibrary/pull/3429/files) then you will understand that this does not work. |
I see. Well only the last three commits are relevant. |
OK let me see what I can do. |
Thanks |
@wischhusen I need some more info since you based your changes on a way outdated master. For the future, before doing any changes make sure that your master branch is up to date with what is in the main repository. So can you please comment on what you have done. As in did you only remove files or did you also update some references in some Modelica files? |
I would be highly interested in a fool-proof step-by-step procedure ;-). I carried out Git Sync on my fork but that was obviously not enough. The changes have almost nothing to do with the Modelica code. I just removed png and eps files from the Resources folder as explained in #3339. And I removed a link to FD.png in the documentation of Dissipation package (top-level docu). This is the only change in the Modelica library that is relevant. |
There are quite a lot of images that were missed it seems. So I'm going to do a different approach of removing first ALL images and then see what the OM document generator complains is missing. |
So I've redone the removal. I can automatically check for images used in the documentation since the OM documentation generator complains about missing files. But for image files used as icons I could only check manually. So it would be good if @wischhusen could have a look especially at the icons to see if something is missing now or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found any image being missing in the documentation of MSL.
But still: Fluid/Components/Tank_PipeAboveTankLevel.png is not used elsewhere.
Both Images/Fluid/Dissipation/heatTransfer and Images/Fluid/Dissipation/pressureLoss seem to be clean now.
Good catch. I removed that one now too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Ref: #3339 Please merge