Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing common spelling mistakes with help of codespell #3454

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Fixing common spelling mistakes with help of codespell #3454

merged 3 commits into from
Feb 28, 2020

Conversation

dietmarw
Copy link
Member

Also manually checked for false positives afterwards.

@dietmarw
Fixing common spelling mistakes with help of codespell
b47df11 
Also manually checked for false positives afterwards.
@dietmarw dietmarw added the documentation Issue addresses the documentation label Feb 27, 2020
HansOlsson
HansOlsson approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

beutlich
beutlich reviewed Feb 28, 2020
View reviewed changes
Modelica/package.mo Outdated Show resolved Hide resolved
@beutlich beutlich added this to the MSL4.0.0 milestone Feb 28, 2020
beutlich
beutlich approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so many matches. Thanks for fixing!

@beutlich beutlich merged commit cb0f512 into modelica:master Feb 28, 2020
@dietmarw dietmarw deleted the spellCheck branch February 28, 2020 08:16
@thorade
Copy link
Contributor

thorade commented Feb 28, 2020

Did you also run it in interactive mode?

@dietmarw
Copy link
Member Author

No.

@thorade
Copy link
Contributor

thorade commented Feb 28, 2020

I only did it once, some time ago, but IIRC interactive mode will find a lot more errors.
Looking at the explanation of the dictionary format:
https://github.com/codespell-project/codespell#dictionary-format
Non-interactive will only handle case 1,
while interactive mode also goes through case 2 entries.

beutlich added a commit that referenced this pull request Feb 29, 2020
@beutlich
Revert "Fixing common spelling mistakes with help of codespell (#3454)"
c6ddd1a 
This reverts commit cb0f512 for ObsoleteModelica4.mo
@beutlich beutlich added the task General work that is not related to a bug or feature label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@beutlich beutlich

Labels
documentation Issue addresses the documentation task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dietmarw @thorade @HansOlsson @beutlich