Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arguments of dp_twoPhaseFriedel_DP and dp_twoPhaseChisholm_DP #3485

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Fix arguments of dp_twoPhaseFriedel_DP and dp_twoPhaseChisholm_DP #3485

merged 2 commits into from
Mar 9, 2020

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Mar 5, 2020

resolves #3483

@beutlich beutlich added bug Critical/severe issue L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation labels Mar 5, 2020
@beutlich beutlich added this to the MSL4.0.0 milestone Mar 5, 2020
@beutlich beutlich self-assigned this Mar 5, 2020
HansOlsson
HansOlsson approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now. I changed to use named arguments for the record constructor, to be safe in case someone reorders the variables in the record constructor.

@beutlich
Copy link
Member Author

beutlich commented Mar 6, 2020

@daiwen Do you see any more similar occurrences?

@qlambert-pro
Copy link
Contributor

No, but we don't have an exhaustive testing mechanism so there may be some more cases hiding.

@beutlich
Copy link
Member Author

beutlich commented Mar 9, 2020

No, but we don't have an exhaustive testing mechanism so there may be some more cases hiding.

@daiwen Nevertheless, please approve.

qlambert-pro
qlambert-pro approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@qlambert-pro qlambert-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes my problem

@beutlich beutlich merged commit 64d3e66 into modelica:master Mar 9, 2020
@beutlich beutlich deleted the fix-arguments branch March 9, 2020 17:02
@beutlich beutlich removed the request for review from henrikt-ma March 9, 2020 17:02
@beutlich beutlich mentioned this pull request Mar 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlambert-pro qlambert-pro qlambert-pro approved these changes

@wischhusen wischhusen wischhusen approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
bug Critical/severe issue L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Incompatible record argument used in a function call
4 participants
@beutlich @qlambert-pro @wischhusen @HansOlsson