Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused type Modelica.Mechanics.MultiBody.Types.Init #3534

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Apr 5, 2020

In 901dd30 for MSL v3.0.1 (more than 10 years ago) all references of Modelica.Mechanics.MultiBody.Types.Init were removed. Also the documentation of Modelica.Mechanics.MultiBody.Types.Init was removed. However, the type itself could neither be deleted nor be marked as obsolete since the obsolete annotation was only invented /back-ported to Modelica Specification 3.2rev2 in 2013. Hence, this superfluous type was an undocumented leftover since 2007.

This PR moves the unused type to ObsoleteModelica4, reintroduces the documentation, adds conversion and a conversion test model.

See #1539.

@beutlich beutlich added L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody task General work that is not related to a bug or feature labels Apr 5, 2020
@beutlich beutlich added this to the MSL4.0.0 milestone Apr 5, 2020
@beutlich beutlich self-assigned this Apr 5, 2020
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@beutlich beutlich removed the request for review from tobolar April 6, 2020 07:54
@beutlich beutlich merged commit 505c9f7 into modelica:master Apr 6, 2020
@beutlich beutlich deleted the remove-unusued-init-type branch April 6, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody task General work that is not related to a bug or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants