Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten image names of Modelica.Fluid.Dissipation #3537

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Shorten image names of Modelica.Fluid.Dissipation #3537

merged 1 commit into from
Apr 8, 2020

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Apr 7, 2020

I also edited/fixed some white spaces. Best is to watch the diff ignoring the white space changes.

Resolves #3536.

@beutlich beutlich added L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation L: Resources Issue addresses Modelica/Resources (excl. C-Sources) task General work that is not related to a bug or feature labels Apr 7, 2020
@beutlich beutlich added this to the MSL4.0.0 milestone Apr 7, 2020
@beutlich beutlich self-assigned this Apr 7, 2020
@beutlich beutlich requested a review from wischhusen April 8, 2020 07:28
wischhusen
wischhusen requested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@wischhusen wischhusen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep in mind that the figures are linked to Modelica.Fluid.Dissipation.Utilities.SharedDocumentation package in order to illustrate the functions. The new names have to be changed here.

img src="modelica://Modelica/Resources/Images/Fluid/Dissipation/pressureLoss/straightPipe/fig_dp_twoPhaseOverall_1.png" alt="fig_dp_twoPhaseOverall_1"

@dietmarw
Copy link
Member

dietmarw commented Apr 8, 2020

@wischhusen Did you take the time to check? Because the link you are pointing out is fixed here:
https://github.com/modelica/ModelicaStandardLibrary/pull/3537/files#diff-20a40879b733f981b24751fd2407c0b5L9672-L9673

So is there anything you found broken?

@wischhusen
Copy link
Contributor

If the pathes/references in the Modelica code have been changed accordingly, everything is fine. It looked like only file names were changed.

maltelenz
maltelenz approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the SystemModeler documentation generator with the branch, and it did not complain about anything relevant to these changes.

Looks good!

dietmarw
dietmarw approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I'm not really sure that this really resolves #3536

@beutlich beutlich removed the request for review from HansOlsson April 8, 2020 09:47
@beutlich beutlich merged commit 4b7e8aa into modelica:master Apr 8, 2020
@beutlich beutlich deleted the dissipation-images branch April 8, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw approved these changes

@maltelenz maltelenz maltelenz approved these changes

@wischhusen wischhusen wischhusen approved these changes

Assignees

@beutlich beutlich

Labels
L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation L: Resources Issue addresses Modelica/Resources (excl. C-Sources) task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Very long filenames in Modelica/Resources
4 participants
@beutlich @dietmarw @wischhusen @maltelenz