-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add division tag around image tags #3554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this check is needless as long as there is no corresponding rule given. Clear, there is a discussion in #3549 but no decission so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the python changes.
I agree with @tobolar that it makes sense to explicitly add a guideline to our documentation if we agree this is the way to go.
That said, these specific changes (to the mo files) look good to me.
Something like this?
|
@christiankral Are you able to contribute to this discussion? You are in the end the Library officer of UsersGuide. To be clear: I like the idea of |
@tobolar OK for you to merge this PR anyway and update the guide lines later in a separate issue? |
I don't know the procedure in detail but wouldn't it lead to lot of warnings being simply ignored? The check itself is fine to me, so ok to merge. |
See also #3549.