Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add division tag around image tags #3554

Merged
merged 2 commits into from
May 14, 2020
Merged

Conversation

beutlich
Copy link
Member

See also #3549.

@beutlich beutlich added the documentation Issue addresses the documentation label May 13, 2020
@beutlich beutlich added this to the MSL4.0.0 milestone May 13, 2020
@beutlich beutlich self-assigned this May 13, 2020
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@beutlich beutlich added the CI Issue that addresses continuous integration label May 13, 2020
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this check is needless as long as there is no corresponding rule given. Clear, there is a discussion in #3549 but no decission so far.

Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the python changes.

I agree with @tobolar that it makes sense to explicitly add a guideline to our documentation if we agree this is the way to go.

That said, these specific changes (to the mo files) look good to me.

@beutlich
Copy link
Member Author

Something like this?

Figures shall be placed outside of paragraphs.
Figures shall not be placed directly within the body context.

@tobolar
Copy link
Contributor

tobolar commented May 14, 2020

@christiankral Are you able to contribute to this discussion? You are in the end the Library officer of UsersGuide.

To be clear: I like the idea of <div>environment. But not sure how this works within another environments, e.g. figures within lists.

@beutlich
Copy link
Member Author

@tobolar OK for you to merge this PR anyway and update the guide lines later in a separate issue?

@tobolar
Copy link
Contributor

tobolar commented May 14, 2020

I don't know the procedure in detail but wouldn't it lead to lot of warnings being simply ignored? The check itself is fine to me, so ok to merge.

@beutlich beutlich merged commit 1dd5311 into modelica:master May 14, 2020
@beutlich beutlich deleted the add-div branch May 14, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issue that addresses continuous integration documentation Issue addresses the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants