Removed potentially singular homotopy operator #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casella
added
bug
beutlich
approved these changes
Jul 7, 2020
beutlich
force-pushed
the
fix-homotopy-3.2.3
branch
from
9a99c40
to
0578da8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplified expression for the vessel port pressure loss always assumped zero pressure loss. This homotopy can lead to singular behaviour in some cases, which were not detected by Dymola that doesn't use homotopy by default, but could affect other tools that do. It was hence removed from MSL master in #3291 with commit 30e8c54
This PR back-ports commit 30e8c54 into maint/3.2.3. Tested successfully in OpenModelica 1.16.0 and Dymola 2020x on
Modelica.Fluid.Examples.Explanatory.MeasuringTemperature, that was previously failing in OpenModelica because of singular simplified model.