Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass extrapolation and verbose from init2 to init3 functions #3889

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

sjoelund
Copy link
Member

@sjoelund sjoelund commented Nov 3, 2021

The extrapolation funcionality was not passed to the init3 function,
whereas it used to be used by init2. This fixes backwards compatibility.

Initial report: OpenModelica/OpenModelica#8075

The extrapolation funcionality was not passed to the init3 function,
whereas it used to be used by init2.

Initial report: OpenModelica/OpenModelica#8075
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@beutlich beutlich self-assigned this Nov 3, 2021
@beutlich beutlich added bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources labels Nov 3, 2021
@beutlich beutlich added this to the MSL4.1.0 milestone Nov 3, 2021
@beutlich beutlich changed the title Pass extrapolation to init3 functions Pass extrapolation and verbose from init2 to init3 functions Nov 3, 2021
@beutlich beutlich enabled auto-merge (squash) November 3, 2021 10:41
@beutlich beutlich removed the request for review from casella November 3, 2021 10:41
@beutlich beutlich merged commit 565fd48 into modelica:master Nov 3, 2021
@beutlich
Copy link
Member

beutlich commented Nov 3, 2021

@sjoelund Thanks for the PR. Can you please back-port to maint/4.0.x branch.

@sjoelund sjoelund deleted the om-issue-8075 branch November 3, 2021 10:54
@sjoelund
Copy link
Member Author

sjoelund commented Nov 3, 2021

@sjoelund Thanks for the PR. Can you please back-port to maint/4.0.x branch.

That shouldn't be necessary. init3 doesn't exist there, right?
https://github.com/modelica/ModelicaStandardLibrary/blob/maint/4.0.x/Modelica/Resources/C-Sources/ModelicaStandardTables.c#L612

@beutlich
Copy link
Member

beutlich commented Nov 3, 2021

Right, it only got introduced for #3691 in master. We have labels to indicate the origin of the issue.

@beutlich beutlich added the V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases) label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants