New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release notes generation #3999
Fix release notes generation #3999
Conversation
5a18620
to
d77574a
Compare
Here's the successful test run: https://github.com/beutlich/ModelicaStandardLibrary/actions/runs/7575836490 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think relying (again) on a third-party service here is non-optimal. Why not run the PDF/HTML generation directly in the GH actions environment?
OK, we can wait until a new release is scheduled. |
d77574a
to
89d5d03
Compare
5e10a6f
to
7493b01
Compare
@Harisankar-Allimangalath Since a new release is about to be scheduled we need to decide how to fix the release notes generation script. The proposed changes work for me as indicated by #4251 (though the free docraptor service only enables 5 documents per months w/o watermark). |
7493b01
to
c5ea2eb
Compare
@beutlich there are 2 weeks left until we branch off. Do you think you and @Harisankar-Allimangalath can fix it by then? |
Since I already spent quite some time on this PR I see three short-term options for the next MSL release:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I go for the pragmatic solution and go for "1. Accept as is".
The previously used docverter service for MD to HTML/PDF conversion was shut down and will not come back. This is an alternative implementation with local MD to HTML conversion and utilizing the docraptor service for HTML to PDF conversion.
c5ea2eb
to
e0a8600
Compare
The previously used docverter service for MD to HTML/PDF conversion was shut down and will not come back. This is an alternative implementation with local MD to HTML conversion and utilizing the docraptor service for HTML to PDF conversion.
It also fixes the GitHub Action introduced by #3886.