Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (and rename) parameters of Modelica.Electrical.Digital.Examples.Utilities.DFF #4176

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Aug 8, 2023

Closes #4174.

Note, that I renamed the two parameters to match the identifiers of the underlying classes. No conversion script is needed for such example components.

@beutlich beutlich added L: Electrical.Digital Issue addresses Modelica.Electrical.Digital example Issue only addresses example(s) labels Aug 8, 2023
@beutlich beutlich added this to the MSL4.1.0 milestone Aug 8, 2023
@beutlich beutlich enabled auto-merge (squash) August 8, 2023 11:50
Copy link
Contributor

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I often think that final parameter propagations are good, I think someone like an MSL sub-library officer is needed to know whether it is the right thing to do here.

@beutlich
Copy link
Member Author

While I often think that final parameter propagations are good, I think someone like an MSL sub-library officer is needed to know whether it is the right thing to do here.

Someone needs to take over, because the original library officers of Electrical.Digital are no loger active.

@hubertus65
Copy link
Member

hubertus65 commented Oct 30, 2023

Yes, that is exactly the problem that the former library officers are no longer active. Here is why I think that adding the finals is the correct solution: I think that without it, it's possible and actually quite easy to get internally inconcistent models.

@henrikt-ma
Copy link
Contributor

Yes, that is exactly the problem that the former library officers are no longer active.

Right. This is a reminder of one of the unavoidable problems we run into due the monolithic MSL architecture.

@hubertus65
Copy link
Member

People leaving due to job change/ retirement has nothing to do with that. We have exactly per-sublibrary officers, so arguably this is the only part of MSL that is not monolithic in terms of practice.

@MartinOtter MartinOtter self-requested a review December 12, 2023 13:23
@GallLeo
Copy link
Contributor

GallLeo commented Dec 12, 2023

MAP-LIB group during monthly meeting:
Just formal issue of no library officer.
Proposal seems fine.

@beutlich beutlich merged commit 26fc7f6 into modelica:master Dec 12, 2023
2 checks passed
@beutlich beutlich deleted the fix-issue4174 branch December 12, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Issue only addresses example(s) L: Electrical.Digital Issue addresses Modelica.Electrical.Digital
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused parameters in Modelica.Electrical.Digital.Examples.Utilities.DFF
6 participants