-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (and rename) parameters of Modelica.Electrical.Digital.Examples.Utilities.DFF #4176
Conversation
7c9b937
to
eac4307
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I often think that final
parameter propagations are good, I think someone like an MSL sub-library officer is needed to know whether it is the right thing to do here.
Someone needs to take over, because the original library officers of Electrical.Digital are no loger active. |
Yes, that is exactly the problem that the former library officers are no longer active. Here is why I think that adding the finals is the correct solution: I think that without it, it's possible and actually quite easy to get internally inconcistent models. |
Right. This is a reminder of one of the unavoidable problems we run into due the monolithic MSL architecture. |
People leaving due to job change/ retirement has nothing to do with that. We have exactly per-sublibrary officers, so arguably this is the only part of MSL that is not monolithic in terms of practice. |
MAP-LIB group during monthly meeting: |
Closes #4174.
Note, that I renamed the two parameters to match the identifiers of the underlying classes. No conversion script is needed for such example components.