-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix position prescribed friction" #4255
Conversation
Duplicate to #3911 |
@beutlich Is it documented how to proceed in such cases or where to find up-to-date binaries? #4178 (comment) is well and good but not that easy to find it. |
They are usually updated by a library officer before tagging a release. See #4250. |
I wonder why this PR was merged bypassing the review process. This is not ideal. 😕 |
Is there any procedure how to handle this before the binaries are updated? |
We had two options so far: You are always free to compile the C-Sources your own (targeting your OS and simulation tool). And: The library officers usally provided them upon request, see your reference to #4178. Of course, we could also update the CI actions to build and deploy the binaries. Edit: Please move this discussion to #4250 or a separate discussion. |
Because "external_c_checks" and "deprecation_checks" failed and there was no information why this failed. As I understand from the discussion above, these checks will further fail until Note, it is planned to have a feature freeze today (12.01.2024, 16:00) |
I do not see that the checks failed: https://github.com/modelica/ModelicaStandardLibrary/actions/runs/7499083151/job/20415248489 and https://github.com/modelica/ModelicaStandardLibrary/actions/runs/7499083151/job/20415248013 The CI always builds all libraries as needed. |
See: #4129 and in "Details" I did not find more details and especially no link to the github actions. I did not manage to get tables from master to run locally on my machine |
Revert "Merge pull request #4255 from modelica/revert-4129-fix-friction"
It says in https://github.com/modelica/ModelicaStandardLibrary/actions/runs/6865804143
and
which should not give any valid reason to revert a PR without proper review in a rush. CI should have just be triggered again. |
Reverts #4129
When simulating a model with the changed friction model the following error appears in Dymola 2024x:
Compiling and linking the model (Visual C++).
dsmodel.c
dsmodel.c(176): error C2065: "ModelicaStandardTables_CombiTable1D_init3": nichtdeklarierter Bezeichner
dsmodel.c(176): error C2064: Ausdruck ergibt keine Funktion, die 337 Argumente bernimmt
Error generating Dymosim.