Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in SharpEdgedOrifice for Loss factors resolved #4258

Merged
merged 1 commit into from Jan 16, 2024

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Jan 13, 2024

This follows #3825 (review) and extracted the original commit of @wischhusen wischhusen@a0002e1 to resolve #3944.

@beutlich beutlich added bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) labels Jan 13, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Jan 13, 2024
@beutlich beutlich enabled auto-merge (squash) January 13, 2024 19:17
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hubertus65 hubertus65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@beutlich beutlich merged commit 68aa656 into modelica:master Jan 16, 2024
2 checks passed
@beutlich beutlich deleted the fix-SharpEdgedOrifice branch January 16, 2024 22:06
@beutlich beutlich removed the request for review from wischhusen January 16, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in the SharpEdgedOrifice for Loss factors
4 participants