Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dimension error of Modelica.Fluid.Machines.BaseClasses.PumpCharacteristics.linearPower #4259

Merged
merged 1 commit into from Jan 18, 2024
Merged

Fix dimension error of Modelica.Fluid.Machines.BaseClasses.PumpCharacteristics.linearPower #4259

merged 1 commit into from Jan 18, 2024

Conversation

beutlich
Copy link
Member

Fixes #4144.

@beutlich beutlich added bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) labels Jan 14, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Jan 14, 2024
@beutlich beutlich enabled auto-merge (squash) January 14, 2024 09:48
@beutlich beutlich enabled auto-merge (squash) January 14, 2024 09:49
@beutlich beutlich mentioned this pull request Jan 14, 2024
Merged
hubertus65
hubertus65 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@hubertus65 hubertus65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear error that was fixed, with a test for the functionality on top.

arunkumar-narasimhan
arunkumar-narasimhan approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@arunkumar-narasimhan arunkumar-narasimhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dimension error fix looks good.

@beutlich beutlich merged commit 43e203e into modelica:master Jan 18, 2024
2 checks passed
@beutlich beutlich deleted the fix-linearPower branch January 18, 2024 05:06
@beutlich beutlich removed the request for review from casella January 18, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertus65 hubertus65 hubertus65 approved these changes

@arunkumar-narasimhan arunkumar-narasimhan arunkumar-narasimhan approved these changes

Assignees
No one assigned
Labels
bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

Dimension mismatch in function linearPower
3 participants
@beutlich @hubertus65 @arunkumar-narasimhan