New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize PressureSlope unit in Media consistently #4262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
force-pushed
the
utilize-PressureRate-unit
branch
from
January 14, 2024 19:49
770cbc2
to
d6fd498
Compare
beutlich
changed the title
Utilize PressureRate unit in Media everywhere
Utilize PressureRate unit in Media consistently
Jan 14, 2024
beutlich
force-pushed
the
utilize-PressureRate-unit
branch
from
January 15, 2024 05:55
d6fd498
to
5c48e64
Compare
maltelenz
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
beutlich
changed the title
Utilize PressureRate unit in Media consistently
Utilize PressureSlope unit in Media consistently
Jan 15, 2024
beutlich
force-pushed
the
utilize-PressureRate-unit
branch
from
January 15, 2024 19:30
6ab5d04
to
ab8ef97
Compare
casella
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of the recently merged PRs #4115 (adding unit "Pa/s") and #4103 (introducing a new type PressureRate with unit "Pa/s").