Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check y - not internal state #4297

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Check y - not internal state #4297

wants to merge 3 commits into from

Conversation

HansOlsson
Copy link
Contributor

@HansOlsson HansOlsson commented Feb 2, 2024 •
edited

Closes #4296

@HansOlsson HansOlsson added L: Blocks Issue addresses Modelica.Blocks ref-result Issue addresses the reference results labels Feb 2, 2024
@HansOlsson HansOlsson added the V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases) label Feb 2, 2024
beutlich
beutlich reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the variance block? Should it be in a similar fashion?

@HansOlsson
Copy link
Contributor Author

What about the variance block? Should it be in a similar fashion?

Ideally yes. But it can wait as that block wasn't updated for this release.

@beutlich
Copy link
Member

beutlich commented Feb 2, 2024

What about the variance block? Should it be in a similar fashion?

Ideally yes. But it can wait as that block wasn't updated for this release.

Hm, so it seems to me that we have some "immature" dev state where Mean was refactored and Variance not yet. That does not sound too promising. You still can prove me wrong here.

@HansOlsson
Copy link
Contributor Author

Hm, so it seems to me that we have some "immature" dev state where Mean was refactored and Variance not yet. That does not sound too promising. You still can prove me wrong here.

I see two possible answers:

  • It's still a step in the right direction, and the Variance-model would require more time to get it right (the formulas are somewhat messy - just computing the integral of u^2 is likely to lead to round-off errors).
  • The Variance model actually benefits from this rewriting.

@beutlich beutlich added this to the MSL4.1.0 milestone Feb 15, 2024
@beutlich beutlich removed the request for review from GallLeo February 22, 2024 06:07
@beutlich beutlich changed the title Check y - not internal state. Check y - not internal state Feb 22, 2024
@beutlich beutlich removed this from the MSL4.1.0 milestone Feb 22, 2024
@HansOlsson HansOlsson mentioned this pull request May 15, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beutlich beutlich beutlich left review comments

@hubertus65 hubertus65 hubertus65 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
L: Blocks Issue addresses Modelica.Blocks ref-result Issue addresses the reference results V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSL 4.1.0 Regressions - Blocks
3 participants
@HansOlsson @beutlich @hubertus65