Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot scripts #4321

Merged
merged 1 commit into from Feb 15, 2024
Merged

Fix plot scripts #4321

merged 1 commit into from Feb 15, 2024

Conversation

HansOlsson
Copy link
Contributor

Closes #4316
I believe these make sense. I don't know exactly what they intended to show, but:

  • wall and heater have somewhat similar heat-flows showing that you heat and it is lost in the wall later on
  • in the other two cases there were already enough variables plotted in that diagram, so I don't think we need the extra one

@HansOlsson HansOlsson added the tool-issue Issue targets a specific Modelica tool only label Feb 15, 2024
@beutlich beutlich changed the title Update plot scripts to work. Fix plot scripts Feb 15, 2024
@beutlich beutlich added the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Feb 15, 2024
Copy link
Collaborator

@m-kessler m-kessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are all fine.

However, the scripts are not very good and should have some general clean-up. But maybe this is another issue.

@beutlich
Copy link
Member

beutlich commented Feb 15, 2024

However, the scripts are not very good and should have some general clean-up. But maybe this is another issue.

@casella Perhaps, MAP-Lib could spend some of its budget to convert the vendor-specific plot scripts to specified figure annotations.

@HansOlsson HansOlsson merged commit ae3e488 into modelica:master Feb 15, 2024
2 checks passed
@HansOlsson HansOlsson deleted the FixDymolaScripts branch February 15, 2024 11:57
@HansOlsson HansOlsson mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Resources Issue addresses Modelica/Resources (excl. C-Sources) tool-issue Issue targets a specific Modelica tool only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSL v4.1.0-beta.1 feedback: broken Dymola plot scripts
3 participants