Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoupledClutches.mos #4350

Merged
merged 1 commit into from Mar 14, 2024
Merged

Update CoupledClutches.mos #4350

merged 1 commit into from Mar 14, 2024

Conversation

DagBruck
Copy link
Contributor

@DagBruck DagBruck commented Mar 1, 2024

Making this change to master branch, duplicate of commit b0f2a98.

Making this change to master branch, duplicate of commit b0f2a98.
@DagBruck DagBruck added the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Mar 1, 2024
@DagBruck DagBruck added this to the MSL4.1.0 milestone Mar 1, 2024
@DagBruck
Copy link
Contributor Author

DagBruck commented Mar 1, 2024

Duplicated from #4348 on the wrong branch.

@HansOlsson HansOlsson self-requested a review March 1, 2024 13:26
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
We could later replace this (and others) with figure-annotations; but best to have a sensible starting point.

@DagBruck DagBruck merged commit 677bec0 into master Mar 14, 2024
6 checks passed
@DagBruck DagBruck deleted the DagBruck-patch-2 branch March 14, 2024 12:27
@beutlich beutlich removed this from the MSL4.1.0 milestone Mar 14, 2024
@Harisankar-Allimangalath
Copy link
Contributor

@HansOlsson @DagBruck we want to backport this to maint\4.1.x right . #4348 was closed . so shall I backport this with a new PR

@DagBruck
Copy link
Contributor Author

@Harisankar-Allimangalath yes, there is every reason to backport it. Thanks.

Harisankar-Allimangalath pushed a commit to Harisankar-Allimangalath/ModelicaStandardLibrary_1 that referenced this pull request Mar 28, 2024
@Harisankar-Allimangalath
Copy link
Contributor

FYI , created PR to back port this @DagBruck @dietmarw @HansOlsson #4371 .

Thankyou

@beutlich beutlich added the tool-issue Issue targets a specific Modelica tool only label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Resources Issue addresses Modelica/Resources (excl. C-Sources) tool-issue Issue targets a specific Modelica tool only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants