-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MultipleResonance.mo #4351
Conversation
Fixed to make type more clear, and make it work in Modelon Impact. Also, removed an unused line of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me
Fixed to make type more clear, and make it work in Modelon Impact. Also, removed an unused line of code.
This does not work in Dymola 2024x, and I cannot see how it would work according to the specification. Longer explanation for why: https://specification.modelica.org/master/overloaded-operators.html#overloaded-constructors There is only one constructor-function in Complex - fromReal where the imaginary part has default-value 0; so the only match we consider would be: How to correct: However, |
@hubertus65 @AHaumer can you please look in to the above suggestion and decide on how to proceed with this . Thankyou |
Addressed by #4374. |
Fixed to make type more clear, and make it work in Modelon Impact. Also, removed an unused line of code.
Fixed to make type more clear, and make it work in Modelon Impact. Also, removed an unused line of code. This is tested in latest version of Modelon Impact, and Dymola, and works in both.